[18.0][MIG] sale_order_lot_generator #3752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_lot_generator Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_lot_generator/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_lot_generator Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_lot_generator/ca/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_lot_generator Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_lot_generator/es/
Currently translated at 12.5% (1 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_lot_generator Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_lot_generator/it/
A lot may have happen, and it is possible to have done some MO, received some PO using this lot, maybe there is even stock on hand with this lot and should not delete it or it is lost everywhere.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_lot_generator Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_lot_generator/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_lot_generator Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_lot_generator/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_lot_generator Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_lot_generator/es/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_lot_generator Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_lot_generator/it/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_lot_generator Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_lot_generator/pt_BR/
hparfr
force-pushed
the
18.0-mig-sale_order_lot_generator
branch
from
2fae935 to
45298dc
Compare
Contributor
|
/ocabot migration sale_order_lot_generator |
| self.assertEqual(self.sol3.lot_id.name, lot_number) | ||
| for line in self.order1.picking_ids.move_line_ids: | ||
| if line.product_id.id == self.prd_flipover.id: | ||
| self.assertEqual(line.lot_id, self.sol1.lot_id) |
Contributor
There was a problem hiding this comment.
@hparfr Could you check why some tests lines are not accessed?
Contributor
Author
There was a problem hiding this comment.
... so tests are not covered by tests !
Contributor
Author
There was a problem hiding this comment.
... and that's good. Because, I didn't pay enough attention. There is no move_lines_ids at this time. So the code inside this for loop is never executing.
Contributor
There was a problem hiding this comment.
Of course. So, could you check why those lines are necessary ? 😅
Contributor
Author
There was a problem hiding this comment.
Thanks for this good catch @rousseldenis
I've just added a fix.
There is no move_lines because there is no quants with these freshly created lots. This tests was probably not working in previous versions. restrict_lot_id is from stock_restrict_lot module. stock_restrict_lot is a dependency of sale_order_lot_selection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.